fix: display token logos from CoW Protocol correctly #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alfetopito
approved these changes
Oct 18, 2023
anxolin
approved these changes
Oct 18, 2023
|
|
||
| // Always lowercase logo URI if it's from CoW Protocol repo | ||
| // Because CoW Protocol repo has all logos in lowercase | ||
| if (logoURI.includes(COW_PROTOCOL_REPO)) return logoURI.toLowerCase() |
There was a problem hiding this comment.
Is this a permanent or temporal solution?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since the recent refactoring to lowerCase all tokens addresses in logo URLs we got broken some token logos, for example
USDMon Mainnet.To fix this, I always lowerCase token logoURI if it's from CoW Protocol repo.
To Test